Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: runtime/vm/isolate_reload_test.cc

Issue 2259013002: Become: Also forward identity hashes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/become.cc ('K') | « runtime/vm/become.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate_reload_test.cc
diff --git a/runtime/vm/isolate_reload_test.cc b/runtime/vm/isolate_reload_test.cc
index 018ed1ce390802e2748200bf86f09c36f916b75d..4543baa994e5b9f7bcc806f9059bb0dfbf3955d4 100644
--- a/runtime/vm/isolate_reload_test.cc
+++ b/runtime/vm/isolate_reload_test.cc
@@ -2816,6 +2816,65 @@ TEST_CASE(IsolateReload_ChangeInstanceFormat8) {
}
+TEST_CASE(IsolateReload_ShapeChangeRetainsHash) {
+ const char* kScript =
+ "class A{\n"
+ " var x;\n"
+ "}\n"
+ "var a, hash1, hash2;\n"
+ "main() {\n"
+ " a = new A();\n"
+ " hash1 = a.hashCode;\n"
+ " return 'okay';\n"
+ "}\n";
+
+ Dart_Handle lib = TestCase::LoadTestScript(kScript, NULL);
+ EXPECT_VALID(lib);
+ EXPECT_STREQ("okay", SimpleInvokeStr(lib, "main"));
+
+ const char* kReloadScript =
+ "class A{\n"
+ " var x, y, z;\n"
+ "}\n"
+ "var a, hash1, hash2;\n"
+ "main() {\n"
+ " hash2 = a.hashCode;\n"
+ " return (hash1 == hash2).toString();\n"
+ "}\n";
+
+ lib = TestCase::ReloadTestScript(kReloadScript);
+ EXPECT_VALID(lib);
+ EXPECT_STREQ("true", SimpleInvokeStr(lib, "main"));
+}
+
+
+TEST_CASE(IsolateReload_StaticTearOffRetainsHash) {
+ const char* kScript =
+ "foo() {}\n"
+ "var hash1, hash2;\n"
+ "main() {\n"
+ " hash1 = foo.hashCode;\n"
+ " return 'okay';\n"
+ "}\n";
+
+ Dart_Handle lib = TestCase::LoadTestScript(kScript, NULL);
+ EXPECT_VALID(lib);
+ EXPECT_STREQ("okay", SimpleInvokeStr(lib, "main"));
+
+ const char* kReloadScript =
+ "foo() {}\n"
+ "var hash1, hash2;\n"
+ "main() {\n"
+ " hash2 = foo.hashCode;\n"
+ " return (hash1 == hash2).toString();\n"
+ "}\n";
+
+ lib = TestCase::ReloadTestScript(kReloadScript);
+ EXPECT_VALID(lib);
+ EXPECT_STREQ("true", SimpleInvokeStr(lib, "main"));
+}
+
+
static bool NothingModifiedCallback(const char* url, int64_t since) {
return false;
}
« runtime/vm/become.cc ('K') | « runtime/vm/become.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698