Issue 22590004: Create NaCl specific frame inner detection function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22590004: Create NaCl specific frame inner detection function. (Closed)

Created:
7 years, 4 months ago by halyavin

Modified:
7 years, 4 months ago

Reviewers:
khim, eaeltsin, khimg

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@master

Visibility:
Public.

Create NaCl specific frame inner detection function. GDB compares frame pointers to detect incorrect frame. We have to create NaCl specific function that ignores base address. This is need since PNaCl erases base address from stack frames. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3600 TEST= none Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gdb.git;a=commit;h=aeafd16

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	gdb/nacl-tdep.c	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

halyavin

7 years, 4 months ago (2013-08-08 13:04:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as raeafd16 (presubmit successful).