Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2258953002: Prevent crashing when collecting some UMA about possible crashing (Closed)

Created:
4 years, 4 months ago by pauljensen
Modified:
4 years, 4 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent crashing when collecting some UMA about possible crashing Previously we were rethrowing exceptions which caused Chrome to crash which threw away our UMA data. Instead return some default values in the rare instances when we would have crashed. This should facilitate collecting UMA on the possible crashes with the only side effect of slightly inaccurate network information in the rare instances where there would have been a crash. BUG=592131 R=xunjieli Committed: https://crrev.com/ebf40db43a06950a2900842c04a94b63f71ad201 Cr-Commit-Position: refs/heads/master@{#412886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pauljensen
Helen, PTAL, thank you!
4 years, 4 months ago (2016-08-18 15:16:03 UTC) #1
xunjieli
lgtm
4 years, 4 months ago (2016-08-18 16:06:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258953002/1
4 years, 4 months ago (2016-08-18 16:13:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 17:48:07 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 17:51:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebf40db43a06950a2900842c04a94b63f71ad201
Cr-Commit-Position: refs/heads/master@{#412886}

Powered by Google App Engine
This is Rietveld 408576698