Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: net/quic/chromium/quic_stream_factory.h

Issue 2258893004: Changes connection migration code to migrate on NetworkMadeDefault (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/quic_stream_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_stream_factory.h
diff --git a/net/quic/chromium/quic_stream_factory.h b/net/quic/chromium/quic_stream_factory.h
index 4e4bf9f8aae38a210b96a6fbc4c9d75eb3d7076b..c1e161dd4f975ee0a0e662aecfe039bafeada89e 100644
--- a/net/quic/chromium/quic_stream_factory.h
+++ b/net/quic/chromium/quic_stream_factory.h
@@ -283,15 +283,20 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
NetworkChangeNotifier::NetworkHandle FindAlternateNetwork(
NetworkChangeNotifier::NetworkHandle old_network);
- // Method that initiates migration of active sessions
- // currently bound to |network| to an alternate network, if one
- // exists. Idle sessions bound to |network| are closed. If there is
- // no alternate network to migrate active sessions onto, active
- // sessions are closed if |force_close| is true, and continue using
- // |network| otherwise. Sessions not bound to |network| are left unchanged.
- void MaybeMigrateOrCloseSessions(NetworkChangeNotifier::NetworkHandle network,
- bool force_close,
- const BoundNetLog& bound_net_log);
+ // Method that initiates migration of active sessions to |new_network|.
+ // If |new_network| is a valid network, sessions that can migrate are
+ // migrated to |new_network|, and sessions not bound to |new_network|
+ // are left unchanged. Sessions with non-migratable streams are closed
+ // if |close_if_cannot_migrate| is true, and continue using their current
+ // network otherwise.
+ //
+ // If |new_network| is NetworkChangeNotifier::kInvalidNetworkHandle,
+ // there is no new network to migrate sessions onto, and all sessions are
+ // closed.
+ void MaybeMigrateOrCloseSessions(
+ NetworkChangeNotifier::NetworkHandle new_network,
+ bool close_if_cannot_migrate,
+ const BoundNetLog& bound_net_log);
// Method that initiates migration of |session| if |session| is
// active and if there is an alternate network than the one to which
« no previous file with comments | « no previous file | net/quic/chromium/quic_stream_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698