components/sync/engine_impl/get_commit_ids.cc - Issue 2258873003: [Sync] Move sessions/ to engine/cycle/ and rename things to match.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/get_commit_ids.cc

Issue 2258873003: [Sync] Move sessions/ to engine/cycle/ and rename things to match. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/engine_impl/directory_update_handler_unittest.cc ('k') | components/sync/engine_impl/get_updates_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/engine_impl/get_commit_ids.cc

diff --git a/components/sync/engine_impl/get_commit_ids.cc b/components/sync/engine_impl/get_commit_ids.cc

index fec5a728d605610e8253efb8674efa72981d1a47..c4816a730774f29304b00fe84df22e46143b330f 100644

--- a/components/sync/engine_impl/get_commit_ids.cc

+++ b/components/sync/engine_impl/get_commit_ids.cc

@@ -58,7 +58,7 @@ void GetCommitIdsForType(syncable::BaseTransaction* trans,

syncable::Directory::Metahandles* out) {

syncable::Directory* dir = trans->directory();

- // Gather the full set of unsynced items and store it in the session. They

+ // Gather the full set of unsynced items and store it in the cycle. They

// are not in the correct order for commit.

std::set<int64_t> ready_unsynced_set;

syncable::Directory::Metahandles all_unsynced_handles;