chrome/browser/sync/test/integration/p2p_sync_refresher.cc - Issue 2258873003: [Sync] Move sessions/ to engine/cycle/ and rename things to match.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/p2p_sync_refresher.cc

Issue 2258873003: [Sync] Move sessions/ to engine/cycle/ and rename things to match. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/p2p_invalidation_forwarder.cc ('k') | chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/p2p_sync_refresher.cc

diff --git a/chrome/browser/sync/test/integration/p2p_sync_refresher.cc b/chrome/browser/sync/test/integration/p2p_sync_refresher.cc

index f344c7600bcd8031be0a6c91b7f7a92706a6c7ff..f48107302ad261f1e24e48a7e6893158cd686c0c 100644

--- a/chrome/browser/sync/test/integration/p2p_sync_refresher.cc

+++ b/chrome/browser/sync/test/integration/p2p_sync_refresher.cc

@@ -8,7 +8,7 @@

#include "chrome/browser/sync/test/integration/sync_datatype_helper.h"

#include "chrome/browser/sync/test/integration/sync_test.h"

#include "components/browser_sync/browser/profile_sync_service.h"

-#include "components/sync/sessions/sync_session_snapshot.h"

+#include "components/sync/engine/cycle/sync_cycle_snapshot.h"

#include "content/public/browser/notification_service.h"

P2PSyncRefresher::P2PSyncRefresher(Profile* profile,

@@ -24,8 +24,7 @@ P2PSyncRefresher::~P2PSyncRefresher() {

void P2PSyncRefresher::OnStateChanged() {}

void P2PSyncRefresher::OnSyncCycleCompleted() {

- const syncer::sessions::SyncSessionSnapshot& snap =

- sync_service_->GetLastSessionSnapshot();

+ const syncer::SyncCycleSnapshot& snap = sync_service_->GetLastCycleSnapshot();

bool is_notifiable_commit =

(snap.model_neutral_state().num_successful_commits > 0);

if (is_notifiable_commit) {