Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2258873002: Remove deprecated DirectoryBasedDartSdk (Closed)

Created:
4 years, 4 months ago by vsm
Modified:
4 years, 4 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove deprecated DirectoryBasedDartSdk We're getting bot failures due to analyzer deprecation messages. R=brianwilkerson@google.com, jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0189013f50e42811536cce1d197008031d18fe82

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M lib/src/analyzer/context.dart View 3 chunks +6 lines, -5 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
vsm
4 years, 4 months ago (2016-08-18 13:40:04 UTC) #3
Jennifer Messerly
lgtm
4 years, 4 months ago (2016-08-18 14:26:19 UTC) #4
Brian Wilkerson
lgtm https://codereview.chromium.org/2258873002/diff/1/lib/src/analyzer/context.dart File lib/src/analyzer/context.dart (right): https://codereview.chromium.org/2258873002/diff/1/lib/src/analyzer/context.dart#newcode186 lib/src/analyzer/context.dart:186: FolderBasedDartSdk _createFolderBasedDartSdk(String sdkPath) { Return "DartSdk"?
4 years, 4 months ago (2016-08-18 14:41:26 UTC) #5
vsm
Committed patchset #1 (id:1) manually as 0189013f50e42811536cce1d197008031d18fe82 (presubmit successful).
4 years, 4 months ago (2016-08-18 14:47:53 UTC) #7
vsm
https://codereview.chromium.org/2258873002/diff/1/lib/src/analyzer/context.dart File lib/src/analyzer/context.dart (right): https://codereview.chromium.org/2258873002/diff/1/lib/src/analyzer/context.dart#newcode186 lib/src/analyzer/context.dart:186: FolderBasedDartSdk _createFolderBasedDartSdk(String sdkPath) { On 2016/08/18 14:41:26, Brian Wilkerson ...
4 years, 4 months ago (2016-08-18 14:50:13 UTC) #8
vsm
4 years, 4 months ago (2016-08-18 14:50:14 UTC) #9
Message was sent while issue was closed. 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698