Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: cc/animation/transform_operations_unittest.cc

Issue 2258833002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/animation/animation_unittest.cc ('k') | cc/blink/web_content_layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/animation/transform_operations_unittest.cc
diff --git a/cc/animation/transform_operations_unittest.cc b/cc/animation/transform_operations_unittest.cc
index 906be862e51960bc63d011ad092383e3b8b26c2b..295df8017b9844b4483dae7f38d28d411b1d4376 100644
--- a/cc/animation/transform_operations_unittest.cc
+++ b/cc/animation/transform_operations_unittest.cc
@@ -24,23 +24,23 @@ TEST(TransformOperationTest, TransformTypesAreUnique) {
std::vector<std::unique_ptr<TransformOperations>> transforms;
std::unique_ptr<TransformOperations> to_add(
- base::WrapUnique(new TransformOperations()));
+ base::MakeUnique<TransformOperations>());
to_add->AppendTranslate(1, 0, 0);
transforms.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendRotate(0, 0, 1, 2);
transforms.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendScale(2, 2, 2);
transforms.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendSkew(1, 0);
transforms.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendPerspective(800);
transforms.push_back(std::move(to_add));
@@ -96,50 +96,50 @@ TEST(TransformOperationTest, MatchTypesDifferentLength) {
std::vector<std::unique_ptr<TransformOperations>> GetIdentityOperations() {
std::vector<std::unique_ptr<TransformOperations>> operations;
std::unique_ptr<TransformOperations> to_add(
- base::WrapUnique(new TransformOperations()));
+ base::MakeUnique<TransformOperations>());
operations.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendTranslate(0, 0, 0);
operations.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendTranslate(0, 0, 0);
to_add->AppendTranslate(0, 0, 0);
operations.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendScale(1, 1, 1);
operations.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendScale(1, 1, 1);
to_add->AppendScale(1, 1, 1);
operations.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendSkew(0, 0);
operations.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendSkew(0, 0);
to_add->AppendSkew(0, 0);
operations.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendRotate(0, 0, 1, 0);
operations.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendRotate(0, 0, 1, 0);
to_add->AppendRotate(0, 0, 1, 0);
operations.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendMatrix(gfx::Transform());
operations.push_back(std::move(to_add));
- to_add = base::WrapUnique(new TransformOperations());
+ to_add = base::MakeUnique<TransformOperations>();
to_add->AppendMatrix(gfx::Transform());
to_add->AppendMatrix(gfx::Transform());
operations.push_back(std::move(to_add));
« no previous file with comments | « cc/animation/animation_unittest.cc ('k') | cc/blink/web_content_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698