android_webview/browser/browser_view_renderer.cc - Issue 2258823002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 2258823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_browser_policy_connector.cc ('k') | android_webview/browser/browser_view_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/browser_view_renderer.cc

diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc

index 63e2f5cefaf497af9d25029a2336dd7a74e26aa2..26065be6d52e98b6a046ff9f49b735197c1f46c7 100644

--- a/android_webview/browser/browser_view_renderer.cc

+++ b/android_webview/browser/browser_view_renderer.cc

@@ -244,10 +244,10 @@ bool BrowserViewRenderer::OnDrawHardware() {

return current_compositor_frame_consumer_->HasFrameOnUI();

}

- std::unique_ptr<ChildFrame> child_frame = base::WrapUnique(new ChildFrame(

+ std::unique_ptr<ChildFrame> child_frame = base::MakeUnique<ChildFrame>(

frame.output_surface_id, std::move(frame.frame), compositor_id_,

viewport_rect_for_tile_priority.IsEmpty(), transform_for_tile_priority,

- offscreen_pre_raster_, external_draw_constraints_.is_layer));

+ offscreen_pre_raster_, external_draw_constraints_.is_layer);

ReturnUnusedResource(

current_compositor_frame_consumer_->PassUncommittedFrameOnUI());