Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Side by Side Diff: android_webview/native/aw_contents_client_bridge_unittest.cc

Issue 2258823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_contents_client_bridge.h" 5 #include "android_webview/native/aw_contents_client_bridge.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 TestCertType(cert_types[i], expected_names[i]); 100 TestCertType(cert_types[i], expected_names[i]);
101 } 101 }
102 } 102 }
103 103
104 void AwContentsClientBridgeTest::TestCertType(SSLClientCertType type, 104 void AwContentsClientBridgeTest::TestCertType(SSLClientCertType type,
105 const std::string& expected_name) { 105 const std::string& expected_name) {
106 cert_request_info_->cert_key_types.clear(); 106 cert_request_info_->cert_key_types.clear();
107 cert_request_info_->cert_key_types.push_back(type); 107 cert_request_info_->cert_key_types.push_back(type);
108 bridge_->SelectClientCertificate( 108 bridge_->SelectClientCertificate(
109 cert_request_info_.get(), 109 cert_request_info_.get(),
110 base::WrapUnique(new TestClientCertificateDelegate(this))); 110 base::MakeUnique<TestClientCertificateDelegate>(this));
111 base::RunLoop().RunUntilIdle(); 111 base::RunLoop().RunUntilIdle();
112 EXPECT_EQ(0, cert_selected_callbacks_); 112 EXPECT_EQ(0, cert_selected_callbacks_);
113 ScopedJavaLocalRef<jobjectArray> key_types = 113 ScopedJavaLocalRef<jobjectArray> key_types =
114 Java_MockAwContentsClientBridge_getKeyTypes(env_, jbridge_); 114 Java_MockAwContentsClientBridge_getKeyTypes(env_, jbridge_);
115 std::vector<std::string> vec; 115 std::vector<std::string> vec;
116 base::android::AppendJavaStringArrayToStringVector(env_, 116 base::android::AppendJavaStringArrayToStringVector(env_,
117 key_types.obj(), 117 key_types.obj(),
118 &vec); 118 &vec);
119 EXPECT_EQ(1u, vec.size()); 119 EXPECT_EQ(1u, vec.size());
120 EXPECT_EQ(expected_name, vec[0]); 120 EXPECT_EQ(expected_name, vec[0]);
(...skipping 29 matching lines...) Expand all
150 base::WrapUnique(new TestClientCertificateDelegate(this))); 150 base::WrapUnique(new TestClientCertificateDelegate(this)));
151 int requestId = Java_MockAwContentsClientBridge_getRequestId(env_, jbridge_); 151 int requestId = Java_MockAwContentsClientBridge_getRequestId(env_, jbridge_);
152 bridge_->ProvideClientCertificateResponse(env_, jbridge_, requestId, nullptr, 152 bridge_->ProvideClientCertificateResponse(env_, jbridge_, requestId, nullptr,
153 nullptr); 153 nullptr);
154 base::RunLoop().RunUntilIdle(); 154 base::RunLoop().RunUntilIdle();
155 EXPECT_EQ(nullptr, selected_cert_); 155 EXPECT_EQ(nullptr, selected_cert_);
156 EXPECT_EQ(1, cert_selected_callbacks_); 156 EXPECT_EQ(1, cert_selected_callbacks_);
157 } 157 }
158 158
159 } // android_webview 159 } // android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | android_webview/native/aw_web_resource_response_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698