Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: android_webview/browser/browser_view_renderer_unittest.cc

Issue 2258823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 #include <queue> 6 #include <queue>
7 #include <utility> 7 #include <utility>
8 8
9 #include "android_webview/browser/browser_view_renderer.h" 9 #include "android_webview/browser/browser_view_renderer.h"
10 #include "android_webview/browser/child_frame.h" 10 #include "android_webview/browser/child_frame.h"
(...skipping 429 matching lines...) Expand 10 before | Expand all | Expand 10 after
440 int frame_number) override { 440 int frame_number) override {
441 switch (frame_number) { 441 switch (frame_number) {
442 case 0: { 442 case 0: {
443 // Draw a frame with initial RTM. 443 // Draw a frame with initial RTM.
444 break; 444 break;
445 } 445 }
446 case 1: { 446 case 1: {
447 // Switch to new RTM. 447 // Switch to new RTM.
448 std::unique_ptr<FakeFunctor> functor(new FakeFunctor); 448 std::unique_ptr<FakeFunctor> functor(new FakeFunctor);
449 functor->Init(window_.get(), 449 functor->Init(window_.get(),
450 base::WrapUnique(new RenderThreadManager( 450 base::MakeUnique<RenderThreadManager>(
451 functor.get(), base::ThreadTaskRunnerHandle::Get()))); 451 functor.get(), base::ThreadTaskRunnerHandle::Get()));
452 browser_view_renderer_->SetCurrentCompositorFrameConsumer( 452 browser_view_renderer_->SetCurrentCompositorFrameConsumer(
453 functor->GetCompositorFrameConsumer()); 453 functor->GetCompositorFrameConsumer());
454 saved_functor_ = std::move(functor_); 454 saved_functor_ = std::move(functor_);
455 functor_ = std::move(functor); 455 functor_ = std::move(functor);
456 break; 456 break;
457 } 457 }
458 case 2: { 458 case 2: {
459 // Draw a frame with the new RTM, but also redraw the initial RTM. 459 // Draw a frame with the new RTM, but also redraw the initial RTM.
460 window_->RequestDrawGL(saved_functor_.get()); 460 window_->RequestDrawGL(saved_functor_.get());
461 break; 461 break;
(...skipping 30 matching lines...) Expand all
492 } 492 }
493 493
494 private: 494 private:
495 std::unique_ptr<FakeFunctor> saved_functor_; 495 std::unique_ptr<FakeFunctor> saved_functor_;
496 OutputSurfaceResourceCountMap expected_return_count_; 496 OutputSurfaceResourceCountMap expected_return_count_;
497 }; 497 };
498 498
499 RENDERING_TEST_F(RenderThreadManagerSwitchTest); 499 RENDERING_TEST_F(RenderThreadManagerSwitchTest);
500 500
501 } // namespace android_webview 501 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/browser/browser_view_renderer.cc ('k') | android_webview/browser/net/android_stream_reader_url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698