Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2258793002: Ascribe erroneous constructors to the resolved element. (Closed)

Created:
4 years, 4 months ago by Johnni Winther
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ascribe erroneous constructors to the resolved element. Erroneous constructor for missing constructor where given the declaring class as enclosing element. Deserialization would fail because the erroneous element could not be found on the class. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/8e454ea3715f5456da30b5239f6f94eb51823eaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M pkg/compiler/lib/src/resolution/constructors.dart View 13 chunks +5 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
4 years, 4 months ago (2016-08-18 08:59:27 UTC) #3
Siggi Cherem (dart-lang)
lgtm
4 years, 4 months ago (2016-08-18 15:25:58 UTC) #4
Johnni Winther
4 years, 4 months ago (2016-08-19 08:05:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8e454ea3715f5456da30b5239f6f94eb51823eaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698