chrome/browser/media/media_stream_devices_controller.h - Issue 2258763002: Add a feature-controlled persistence checkbox to geolocation prompts on desktop Views platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/media_stream_devices_controller.h

Issue 2258763002: Add a feature-controlled persistence checkbox to geolocation prompts on desktop Views platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-infobardelegate-clean

Patch Set: Rebase, add dependent Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/media/media_stream_devices_controller.cc » ('j') | chrome/browser/permissions/permission_context_base_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/media_stream_devices_controller.h

diff --git a/chrome/browser/media/media_stream_devices_controller.h b/chrome/browser/media/media_stream_devices_controller.h

index cd6ba107b4ae9843ceca6909de68d004beb78d27..678d2e081b6c990e2d0425c81f7fdc3edc186520 100644

--- a/chrome/browser/media/media_stream_devices_controller.h

+++ b/chrome/browser/media/media_stream_devices_controller.h

@@ -63,8 +63,7 @@ class MediaStreamDevicesController : public PermissionRequest {

// PermissionRequest instead of a custom infobar delegate.

void GroupedRequestFinished(bool audio_accepted, bool video_accepted);

- bool persist() const { return persist_; }

- void set_persist(bool persist) { persist_ = persist; }

+ bool ShouldShowPersistenceToggle() const override;

// PermissionRequest:

int GetIconId() const override;

@@ -140,9 +139,6 @@ class MediaStreamDevicesController : public PermissionRequest {

// audio/video devices was granted or not.

content::MediaResponseCallback callback_;

- // Whether the permissions granted or denied by the user should be persisted.

- bool persist_;

DISALLOW_COPY_AND_ASSIGN(MediaStreamDevicesController);

};