Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2258753003: Fix more broken installer tests. (Closed)

Created:
4 years, 4 months ago by grt (UTC plus 2)
Modified:
4 years, 4 months ago
Reviewers:
calamity
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix more broken installer tests. r409635 added some new tests that need the same fix introduced in r410945 in response to r409132. BUG=633490 TBR=calamity@chromium.org Committed: https://crrev.com/02aff45fcb89e6b0ca15bba1ed730028e370be1b Cr-Commit-Position: refs/heads/master@{#412790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/test/mini_installer/config/chrome_system_updated.prop View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/mini_installer/config/chrome_user_updated.prop View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
grt (UTC plus 2)
4 years, 4 months ago (2016-08-18 09:32:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258753003/1
4 years, 4 months ago (2016-08-18 09:33:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 10:22:06 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 10:24:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02aff45fcb89e6b0ca15bba1ed730028e370be1b
Cr-Commit-Position: refs/heads/master@{#412790}

Powered by Google App Engine
This is Rietveld 408576698