Issue 225873004: DevTools: Handle the F8 shortcut forwarded from the inspected page

Issue 225873004: DevTools: Handle the F8 shortcut forwarded from the inspected page (Closed)

Created:
6 years, 8 months ago by apavlov

Modified:
6 years, 8 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Handle the F8 shortcut forwarded from the inspected page R=pfeldman, vsevik BUG=160510 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171463

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Add FIXME #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -15 lines)			Patch
M	LayoutTests/http/tests/inspector/debugger-test.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/sources/debugger/debugger-step-into-custom-element-callbacks.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/devtools.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	Source/devtools/front_end/ForwardedInputEventHandler.js	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/InspectorFrontendAPI.js	View	1 2	2 chunks	+13 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/InspectorFrontendHostStub.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/Main.js	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/SourcesPanel.js	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/externs.js	View		2 chunks	+12 lines, -10 lines	0 comments	Download
M	Source/devtools/front_end/inspector.html	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View	1 2	1 chunk	+8 lines, -1 line	0 comments	Download
M	Source/web/InspectorFrontendClientImpl.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/225873004/diff/20001/Source/devtools/front_end/ForwardedInputEventHandler.js File Source/devtools/front_end/ForwardedInputEventHandler.js (right): https://codereview.chromium.org/225873004/diff/20001/Source/devtools/front_end/ForwardedInputEventHandler.js#newcode21 Source/devtools/front_end/ForwardedInputEventHandler.js:21: if (type === "keydown" && keyIdentifier === "F8" ...

6 years, 8 months ago (2014-04-14 13:04:02 UTC) #3

apavlov

On 2014/04/14 13:04:02, pfeldman wrote: > lgtm > > https://codereview.chromium.org/225873004/diff/20001/Source/devtools/front_end/ForwardedInputEventHandler.js > File Source/devtools/front_end/ForwardedInputEventHandler.js (right): > ...

6 years, 8 months ago (2014-04-14 13:16:56 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/225873004/40001

6 years, 8 months ago (2014-04-14 13:17:04 UTC) #6

Message was sent while issue was closed.

Change committed as 171463

Expand Messages | Collapse Messages