Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/work_queue.h

Issue 2258713004: Make tasks cancellable inside the blink scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Various comment nits addressed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/work_queue.h
diff --git a/third_party/WebKit/Source/platform/scheduler/base/work_queue.h b/third_party/WebKit/Source/platform/scheduler/base/work_queue.h
index 977c27fda7ab0ab40c4363a464017913b5e5c371..36e6fb72b4cf1693a696e2b5a53cb1dcfb3ffde3 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/work_queue.h
+++ b/third_party/WebKit/Source/platform/scheduler/base/work_queue.h
@@ -19,9 +19,14 @@ namespace scheduler {
namespace internal {
class WorkQueueSets;
+// This class keeps track of immediate and delayed tasks which are due to run
+// now. It interfaces deeply with WorkQueueSets which keeps track of which queue
+// (with a given priority) contains the oldest task.
class BLINK_PLATFORM_EXPORT WorkQueue {
public:
- WorkQueue(TaskQueueImpl* task_queue, const char* name);
+ WorkQueue(TaskQueueImpl* task_queue,
+ const char* name,
+ TaskQueueImpl::Task::ComparatorFn queue_comparator);
~WorkQueue();
// Associates this work queue with the given work queue sets. This must be
@@ -51,15 +56,20 @@ class BLINK_PLATFORM_EXPORT WorkQueue {
// the head changed.
void Push(TaskQueueImpl::Task task);
- // Pushes the task onto the |work_queue_|, sets the |enqueue_order| and
- // informs the WorkQueueSets if the head changed.
- void PushAndSetEnqueueOrder(TaskQueueImpl::Task task,
- EnqueueOrder enqueue_order);
+ // Removes a cancelled task from the |work_queue_|. Note |key| isn't required
+ // to be the original task posted, it can be a fake key constructed by
+ // TaskQueueImpl::Task::CreateFakeTaskFromHandle.
+ bool CancelTask(const TaskQueueImpl::Task& key);
+
+ // Returns true if |work_queue_| contains a task matching |key|. Note |key|
+ // isn't required to be the original task posted, it can be a fake key
+ // constructed by TaskQueueImpl::Task::CreateFakeTaskFromHandle.
+ bool IsTaskPending(const TaskQueueImpl::Task& key) const;
// Swap the |work_queue_| with |incoming_queue| and informs the
// WorkQueueSets if the head changed. Assumes |task_queue_->any_thread_lock_|
// is locked.
- void SwapLocked(std::queue<TaskQueueImpl::Task>& incoming_queue);
+ void SwapLocked(TaskQueueImpl::ComparatorQueue& incoming_queue);
size_t Size() const { return work_queue_.size(); }
@@ -83,7 +93,7 @@ class BLINK_PLATFORM_EXPORT WorkQueue {
bool ShouldRunBefore(const WorkQueue* other_queue) const;
private:
- std::queue<TaskQueueImpl::Task> work_queue_;
+ TaskQueueImpl::ComparatorQueue work_queue_;
WorkQueueSets* work_queue_sets_; // NOT OWNED.
TaskQueueImpl* task_queue_; // NOT OWNED.
size_t work_queue_set_index_;

Powered by Google App Engine
This is Rietveld 408576698