third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc - Issue 2258713004: Make tasks cancellable inside the blink scheduler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc

Issue 2258713004: Make tasks cancellable inside the blink scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc ('K') | « third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc ('k') | third_party/WebKit/public/platform/scheduler/base/task_queue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc b/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc

index 029929795e71380fa1a528ebddc6b045148cb955..75f472e6b582a8fa1540cc54d4fb45f4b30e778a 100644

--- a/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc

+++ b/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc

@@ -86,6 +86,7 @@ void WebThreadImplForWorkerScheduler::WillDestroyCurrentMessageLoop() {

idle_task_runner_ = nullptr;

web_scheduler_.reset();

worker_scheduler_.reset();

+ web_task_runner_.reset();

Sami 2016/08/18 15:53:44 Did you mean to make this change?

alex clarke (OOO till 29th) 2016/08/18 16:51:41 Yes, it's not strictly needed in this patch. I was

Sami 2016/08/18 17:12:18 Okay, just checking it was intended.

}

std::unique_ptr<scheduler::WorkerScheduler>