base/debug/activity_analyzer.cc - Issue 2258713003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/activity_analyzer.cc

Issue 2258713003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/debug/activity_analyzer.cc

diff --git a/base/debug/activity_analyzer.cc b/base/debug/activity_analyzer.cc

index 438c24186f33ba871cdb53ea257c1cc5d3048585..79d513b5af6c61a64b2ab4d0188c51db8fe2b329 100644

--- a/base/debug/activity_analyzer.cc

+++ b/base/debug/activity_analyzer.cc

@@ -52,10 +52,9 @@ std::unique_ptr<GlobalActivityAnalyzer> GlobalActivityAnalyzer::CreateWithFile(

if (!FilePersistentMemoryAllocator::IsFileAcceptable(*mmfile, true))

return nullptr;

- return WrapUnique(new GlobalActivityAnalyzer(

- WrapUnique(new FilePersistentMemoryAllocator(

- std::move(mmfile), 0, 0, base::StringPiece(),

- true))));

+ return WrapUnique(

+ new GlobalActivityAnalyzer(MakeUnique<FilePersistentMemoryAllocator>(

+ std::move(mmfile), 0, 0, base::StringPiece(), true)));

}

#endif // !defined(OS_NACL)

« no previous file with comments | « base/containers/mru_cache_unittest.cc ('k') | base/debug/activity_analyzer_unittest.cc » ('j') | no next file with comments »