base/task_scheduler/scheduler_service_thread.cc - Issue 2258713003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/scheduler_service_thread.cc

Issue 2258713003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/metrics/persistent_sample_map_unittest.cc ('K') | « base/task_scheduler/priority_queue_unittest.cc ('k') | base/task_scheduler/scheduler_worker_pool_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/task_scheduler/scheduler_service_thread.cc

diff --git a/base/task_scheduler/scheduler_service_thread.cc b/base/task_scheduler/scheduler_service_thread.cc

index 9f91907742bf8913799c8b11aefbf3b7250fd463..ef11df321c0301663d83106817edaca9de97add5 100644

--- a/base/task_scheduler/scheduler_service_thread.cc

+++ b/base/task_scheduler/scheduler_service_thread.cc

@@ -71,12 +71,10 @@ SchedulerServiceThread::~SchedulerServiceThread() = default;

// static

std::unique_ptr<SchedulerServiceThread> SchedulerServiceThread::Create(

TaskTracker* task_tracker, DelayedTaskManager* delayed_task_manager) {

- std::unique_ptr<SchedulerWorker> worker =

- SchedulerWorker::Create(

- ThreadPriority::NORMAL,

- WrapUnique(new ServiceThreadDelegate(delayed_task_manager)),

- task_tracker,

- SchedulerWorker::InitialState::ALIVE);

+ std::unique_ptr<SchedulerWorker> worker = SchedulerWorker::Create(

+ ThreadPriority::NORMAL,

+ MakeUnique<ServiceThreadDelegate>(delayed_task_manager), task_tracker,

+ SchedulerWorker::InitialState::ALIVE);

if (!worker)

return nullptr;