Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: base/metrics/persistent_sample_map_unittest.cc

Issue 2258713003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/persistent_sample_map_unittest.cc
diff --git a/base/metrics/persistent_sample_map_unittest.cc b/base/metrics/persistent_sample_map_unittest.cc
index c3f2474b8617ef30a6cb60c12626cc836b70987d..8e070689053099a17d3e62c9722691318b507f8d 100644
--- a/base/metrics/persistent_sample_map_unittest.cc
+++ b/base/metrics/persistent_sample_map_unittest.cc
@@ -16,16 +16,16 @@ namespace {
std::unique_ptr<PersistentHistogramAllocator> CreateHistogramAllocator(
size_t bytes) {
- return WrapUnique(new PersistentHistogramAllocator(
- WrapUnique(new LocalPersistentMemoryAllocator(bytes, 0, ""))));
+ return MakeUnique<PersistentHistogramAllocator>(
+ WrapUnique(new LocalPersistentMemoryAllocator(bytes, 0, "")));
Nico 2016/09/12 14:10:17 The inner WrapUnique() can't be a MakeUnique()? (I
Adam Rice 2016/09/13 06:35:32 Just a quirk of the conversion process. I assumed
}
std::unique_ptr<PersistentHistogramAllocator> DuplicateHistogramAllocator(
PersistentHistogramAllocator* original) {
- return WrapUnique(
- new PersistentHistogramAllocator(WrapUnique(new PersistentMemoryAllocator(
+ return MakeUnique<PersistentHistogramAllocator>(
+ WrapUnique(new PersistentMemoryAllocator(
Nico 2016/09/12 14:10:17 ditto
Adam Rice 2016/09/13 06:35:32 Done.
const_cast<void*>(original->data()), original->length(), 0,
- original->Id(), original->Name(), false))));
+ original->Id(), original->Name(), false)));
}
TEST(PersistentSampleMapTest, AccumulateTest) {
« no previous file with comments | « base/metrics/persistent_histogram_allocator_unittest.cc ('k') | base/task_scheduler/priority_queue_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698