base/files/important_file_writer_unittest.cc - Issue 2258713003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/important_file_writer_unittest.cc

Issue 2258713003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/files/important_file_writer_unittest.cc

diff --git a/base/files/important_file_writer_unittest.cc b/base/files/important_file_writer_unittest.cc

index 43e051ebcfadf108e3a244420c5a01d5397396a9..c6168e4fc21fd5407edaa1f7272a3f848b53d7ba 100644

--- a/base/files/important_file_writer_unittest.cc

+++ b/base/files/important_file_writer_unittest.cc

@@ -104,7 +104,7 @@ TEST_F(ImportantFileWriterTest, Basic) {

ImportantFileWriter writer(file_, ThreadTaskRunnerHandle::Get());

EXPECT_FALSE(PathExists(writer.path()));

EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());

- writer.WriteNow(WrapUnique(new std::string("foo")));

+ writer.WriteNow(MakeUnique<std::string>("foo"));

RunLoop().RunUntilIdle();

EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());

@@ -117,7 +117,7 @@ TEST_F(ImportantFileWriterTest, BasicWithSuccessfulWriteObserver) {

EXPECT_FALSE(PathExists(writer.path()));

EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());

successful_write_observer_.ObserveNextSuccessfulWrite(&writer);

- writer.WriteNow(WrapUnique(new std::string("foo")));

+ writer.WriteNow(MakeUnique<std::string>("foo"));

RunLoop().RunUntilIdle();

// Confirm that the observer is invoked.

@@ -128,7 +128,7 @@ TEST_F(ImportantFileWriterTest, BasicWithSuccessfulWriteObserver) {

// Confirm that re-installing the observer works for another write.

EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());

successful_write_observer_.ObserveNextSuccessfulWrite(&writer);

- writer.WriteNow(WrapUnique(new std::string("bar")));

+ writer.WriteNow(MakeUnique<std::string>("bar"));

RunLoop().RunUntilIdle();

EXPECT_TRUE(successful_write_observer_.GetAndResetObservationState());

@@ -138,7 +138,7 @@ TEST_F(ImportantFileWriterTest, BasicWithSuccessfulWriteObserver) {

// Confirm that writing again without re-installing the observer doesn't

// result in a notification.

EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());

- writer.WriteNow(WrapUnique(new std::string("baz")));

+ writer.WriteNow(MakeUnique<std::string>("baz"));

RunLoop().RunUntilIdle();

EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());

« no previous file with comments | « base/debug/activity_tracker_unittest.cc ('k') | base/json/json_writer_unittest.cc » ('j') | base/metrics/persistent_sample_map_unittest.cc » ('J')