Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2258703004: [sql] Retry post-poison open as soon as possible. (Closed)

Created:
4 years, 4 months ago by Scott Hess - ex-Googler
Modified:
4 years, 4 months ago
Reviewers:
afakhry
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Retry post-poison open as soon as possible. sql::Connection::Open() retries the open if the handle is poisoned by the error callback. The assumption is that the error callback likely razed or recovered the database, and since there can be no outstanding statements the open can be safely retried. This change adds this handling to call which attempts to probe the database for basic validity. BUG=none Committed: https://crrev.com/bccd300e8c0aa5f5cd255b24b5b709012c0f4355 Cr-Commit-Position: refs/heads/master@{#413292}

Patch Set 1 #

Total comments: 8

Patch Set 2 : nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M sql/connection.cc View 1 1 chunk +17 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Scott Hess - ex-Googler
Turns out this was already being tested by SQLConnectionTest.RazeCallbackReopen. It's just moving the call forward ...
4 years, 4 months ago (2016-08-18 21:21:19 UTC) #4
Scott Hess - ex-Googler
On 2016/08/18 21:21:19, Scott Hess wrote: > Turns out this was already being tested by ...
4 years, 4 months ago (2016-08-18 21:30:44 UTC) #5
afakhry
https://codereview.chromium.org/2258703004/diff/1/sql/connection.cc File sql/connection.cc (right): https://codereview.chromium.org/2258703004/diff/1/sql/connection.cc#newcode1703 sql/connection.cc:1703: err = ExecuteAndReturnErrorCode("PRAGMA auto_vacuum"); Shouldn't we use Execute() instead ...
4 years, 4 months ago (2016-08-18 21:32:29 UTC) #6
Scott Hess - ex-Googler
https://codereview.chromium.org/2258703004/diff/1/sql/connection.cc File sql/connection.cc (right): https://codereview.chromium.org/2258703004/diff/1/sql/connection.cc#newcode1703 sql/connection.cc:1703: err = ExecuteAndReturnErrorCode("PRAGMA auto_vacuum"); On 2016/08/18 21:32:29, afakhry wrote: ...
4 years, 4 months ago (2016-08-18 22:06:53 UTC) #7
afakhry
lgtm https://codereview.chromium.org/2258703004/diff/1/sql/connection.cc File sql/connection.cc (right): https://codereview.chromium.org/2258703004/diff/1/sql/connection.cc#newcode1703 sql/connection.cc:1703: err = ExecuteAndReturnErrorCode("PRAGMA auto_vacuum"); On 2016/08/18 22:06:53, Scott ...
4 years, 4 months ago (2016-08-19 15:25:09 UTC) #10
Scott Hess - ex-Googler
https://codereview.chromium.org/2258703004/diff/1/sql/connection.cc File sql/connection.cc (right): https://codereview.chromium.org/2258703004/diff/1/sql/connection.cc#newcode1706 sql/connection.cc:1706: OnSqliteError(err, NULL, "PRAGMA auto_vacuum"); On 2016/08/19 15:25:09, afakhry wrote: ...
4 years, 4 months ago (2016-08-19 21:51:03 UTC) #11
Scott Hess - ex-Googler
nullptr
4 years, 4 months ago (2016-08-19 21:51:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258703004/20001
4 years, 4 months ago (2016-08-19 21:52:33 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-20 00:08:19 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 00:11:31 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bccd300e8c0aa5f5cd255b24b5b709012c0f4355
Cr-Commit-Position: refs/heads/master@{#413292}

Powered by Google App Engine
This is Rietveld 408576698