DescriptionRevert of Remove content::NotificationPermissionDispatcher. (patchset #5 id:80001 of https://codereview.chromium.org/2244913002/ )
Reason for revert:
Causing failure on Builder WebKit Linux Leak
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/22036
request-permission-detached-context.html
15:25:46.371 7635 worker/0 http/tests/notifications/request-permission-detached-context.html leaked
15:25:46.371 7635 Xlib: extension "RANDR" missing on display ":9".
15:25:46.371 7635 Xlib: extension "RANDR" missing on display ":9".
15:25:46.374 17565 [4/95] http/tests/notifications/request-permission-detached-context.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
15:25:46.372 7635 worker/0 http/tests/notifications/request-permission-detached-context.html failed:
15:25:46.372 7635 worker/0 leak detected: ({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
Original issue's description:
> Remove content::NotificationPermissionDispatcher.
>
> blink::Notification can make calls to the Mojo PermissionService itself.
>
> BUG=561879
>
> Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> Cr-Commit-Position: refs/heads/master@{#412636}
TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerkerk@chromium.org,peter@chromium.org,reillyg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=561879
Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
Cr-Commit-Position: refs/heads/master@{#412678}
Patch Set 1 #Messages
Total messages: 9 (3 generated)
|