Issue 225863008: Mojo: Fix my LOG_IF(ERROR, ...) from r262803.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225863008: Mojo: Fix my LOG_IF(ERROR, ...) from r262803. (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Fix my LOG_IF(ERROR, ...) from r262803. Oops, I inverted the condition. R=sky@chromium.org TBR=sky@chromium.org BUG=360081 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262918

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/system/channel.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/225863008/1

6 years, 8 months ago (2014-04-09 23:46:46 UTC) #3

sky

Ha! LGTM On Wed, Apr 9, 2014 at 4:46 PM, <commit-bot@chromium.org> wrote: > CQ is ...

6 years, 8 months ago (2014-04-10 03:06:00 UTC) #4

viettrungluu

Committed patchset #1 manually as r262918 (presubmit successful).

6 years, 8 months ago (2014-04-10 05:00:05 UTC) #6

commit-bot: I haz the power

6 years, 8 months ago (2014-04-10 05:00:11 UTC) #7

Message was sent while issue was closed.

Failed to apply the patch.
Sending        mojo/system/channel.cc
Transmitting file data .svn: Commit failed (details follow):
svn: File '/trunk/src/mojo/system/channel.cc' is out of date

Expand Messages | Collapse Messages