Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2258603003: Include only stuff you need, part 2: ast.h, ast-value-factory.h in ports. (Closed)

Created:
4 years, 4 months ago by marja
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Include only stuff you need, part 2: ast.h, ast-value-factory.h in ports. Rebuilding (after touching certain files) is crazy slow because includes are out of control. Fixing it: - Don't include stuff in headers unless necessary. - Include the stuff you need, not some other stuff that happens to include the stuff you need. BUG=v8:5294 Committed: https://crrev.com/038be51756b3352460383dbf542fef333d4c45c3 Cr-Commit-Position: refs/heads/master@{#38770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/codegen-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/codegen-mips.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/codegen-mips64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/codegen-ppc.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/s390/codegen-s390.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/codegen-x87.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-18 13:28:42 UTC) #6
marja
Owners, pls review: rmcilroy@: arm/, arm64/ Somebody from imgtec: mips/, mips64/ Somebody from ibm: ppc/. ...
4 years, 4 months ago (2016-08-19 08:23:00 UTC) #8
rmcilroy
lgtm
4 years, 4 months ago (2016-08-19 10:06:08 UTC) #9
akos.palfi.imgtec
lgtm
4 years, 4 months ago (2016-08-19 10:24:49 UTC) #10
john.yan
lgtm
4 years, 4 months ago (2016-08-19 14:23:09 UTC) #11
Weiliang
lgtm
4 years, 4 months ago (2016-08-22 04:18:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258603003/1
4 years, 4 months ago (2016-08-22 07:54:36 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 08:16:47 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 08:17:02 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/038be51756b3352460383dbf542fef333d4c45c3
Cr-Commit-Position: refs/heads/master@{#38770}

Powered by Google App Engine
This is Rietveld 408576698