blimp/client/core/contents/blimp_contents_impl_unittest.cc - Issue 2258563003: Added features to BlimpClientContext and BlimpContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_contents_impl_unittest.cc

Issue 2258563003: Added features to BlimpClientContext and BlimpContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ime_feature_move

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/contents/android/blimp_contents_factory.cc ('K') | « blimp/client/core/contents/blimp_contents_impl.cc ('k') | blimp/client/core/contents/blimp_contents_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/blimp_contents_impl_unittest.cc

diff --git a/blimp/client/core/contents/blimp_contents_impl_unittest.cc b/blimp/client/core/contents/blimp_contents_impl_unittest.cc

index 98fa2066246edf05c0c085cd0116196bd5a7edec..892863a7debec609dcbaf40a18c25461927a72d2 100644

--- a/blimp/client/core/contents/blimp_contents_impl_unittest.cc

+++ b/blimp/client/core/contents/blimp_contents_impl_unittest.cc

@@ -33,13 +33,11 @@ class MockBlimpContentsObserver : public BlimpContentsObserver {

TEST(BlimpContentsImplTest, LoadURLAndNotifyObservers) {

base::MessageLoop loop;

- BlimpContentsImpl blimp_contents(kDummyTabId);

+ FakeNavigationFeature feature;

+ BlimpContentsImpl blimp_contents(kDummyTabId, &feature, nullptr);

BlimpNavigationControllerImpl& navigation_controller =

blimp_contents.GetNavigationController();

- FakeNavigationFeature feature;

- feature.SetDelegate(1, &navigation_controller);

- navigation_controller.SetNavigationFeatureForTesting(&feature);

testing::StrictMock<MockBlimpContentsObserver> observer1(&blimp_contents);

testing::StrictMock<MockBlimpContentsObserver> observer2(&blimp_contents);