blimp/client/core/contents/blimp_contents_impl.h - Issue 2258563003: Added features to BlimpClientContext and BlimpContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_contents_impl.h

Issue 2258563003: Added features to BlimpClientContext and BlimpContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ime_feature_move

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/contents/android/blimp_contents_factory.cc ('K') | « blimp/client/core/contents/android/blimp_contents_factory.cc ('k') | blimp/client/core/contents/blimp_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/blimp_contents_impl.h

diff --git a/blimp/client/core/contents/blimp_contents_impl.h b/blimp/client/core/contents/blimp_contents_impl.h

index 1110ccde6761bcdddd12dd9fc5bad20774843d16..3b8abb0783a84e17f450ac60e36457f94ed65234 100644

--- a/blimp/client/core/contents/blimp_contents_impl.h

+++ b/blimp/client/core/contents/blimp_contents_impl.h

@@ -25,11 +25,16 @@ class BlimpContentsImplAndroid;

class BlimpContentsObserver;

class BlimpNavigationController;

+class ImeFeature;

+class NavigationFeature;

class BlimpContentsImpl : public BlimpContents,

public BlimpNavigationControllerDelegate {

public:

- explicit BlimpContentsImpl(int id);

+ // Ownership of the features remains with the caller.

+ explicit BlimpContentsImpl(int id,

+ NavigationFeature* navigation_feature,

+ ImeFeature* ime_feature);

~BlimpContentsImpl() override;

#if defined(OS_ANDROID)