Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: chromecast/crash/linux/synchronized_minidump_manager_unittest.cc

Issue 2258493003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/linux/synchronized_minidump_manager.cc ('k') | chromecast/media/cdm/cast_cdm_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
diff --git a/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc b/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
index 555e963f2a4e123affe3d96897f7dc3707bc7a94..7a0ff5867c1e8a625bceab61d3a50b0539766c8b 100644
--- a/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
+++ b/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
@@ -246,7 +246,7 @@ TEST_F(SynchronizedMinidumpManagerTest,
// Test that the manager tried to log the entry and failed.
SynchronizedMinidumpManagerSimple manager;
- manager.SetDumpInfoToWrite(base::WrapUnique(new DumpInfo(&val)));
+ manager.SetDumpInfoToWrite(base::MakeUnique<DumpInfo>(&val));
ASSERT_TRUE(manager.DoWorkLocked());
ASSERT_FALSE(manager.add_entry_return_code());
@@ -266,7 +266,7 @@ TEST_F(SynchronizedMinidumpManagerTest,
// Write the first entry.
SynchronizedMinidumpManagerSimple manager;
manager.SetDumpInfoToWrite(
- base::WrapUnique(new DumpInfo("dump1", "log1", now, params)));
+ base::MakeUnique<DumpInfo>("dump1", "log1", now, params));
ASSERT_TRUE(manager.DoWorkLocked());
ASSERT_TRUE(manager.add_entry_return_code());
@@ -277,7 +277,7 @@ TEST_F(SynchronizedMinidumpManagerTest,
// Write the second entry.
manager.SetDumpInfoToWrite(
- base::WrapUnique(new DumpInfo("dump2", "log2", now, params)));
+ base::MakeUnique<DumpInfo>("dump2", "log2", now, params));
ASSERT_TRUE(manager.DoWorkLocked());
ASSERT_TRUE(manager.add_entry_return_code());
@@ -298,7 +298,7 @@ TEST_F(SynchronizedMinidumpManagerTest, AcquireLockFile_WaitsForOtherThread) {
const int sleep_time_ms = 100;
SleepySynchronizedMinidumpManagerSimple sleepy_manager(sleep_time_ms);
sleepy_manager.SetDumpInfoToWrite(
- base::WrapUnique(new DumpInfo("dump", "log", now, params)));
+ base::MakeUnique<DumpInfo>("dump", "log", now, params));
base::Thread sleepy_thread("sleepy");
sleepy_thread.Start();
sleepy_thread.task_runner()->PostTask(
@@ -316,7 +316,7 @@ TEST_F(SynchronizedMinidumpManagerTest, AcquireLockFile_WaitsForOtherThread) {
// the dump.
SynchronizedMinidumpManagerSimple manager;
manager.SetDumpInfoToWrite(
- base::WrapUnique(new DumpInfo("dump", "log", now, params)));
+ base::MakeUnique<DumpInfo>("dump", "log", now, params));
EXPECT_TRUE(manager.DoWorkLocked());
EXPECT_TRUE(manager.add_entry_return_code());
@@ -389,7 +389,7 @@ TEST_F(SynchronizedMinidumpManagerTest,
FakeSynchronizedMinidumpUploader uploader;
SynchronizedMinidumpManagerSimple producer;
producer.SetDumpInfoToWrite(
- base::WrapUnique(new DumpInfo("dump1", "log1", now, params)));
+ base::MakeUnique<DumpInfo>("dump1", "log1", now, params));
const int max_dumps = SynchronizedMinidumpManager::kRatelimitPeriodMaxDumps;
produce_dumps(producer, max_dumps);
@@ -405,7 +405,7 @@ TEST_F(SynchronizedMinidumpManagerTest, Upload_FailsWhenTooManyRecentDumps) {
FakeSynchronizedMinidumpUploader uploader;
SynchronizedMinidumpManagerSimple producer;
producer.SetDumpInfoToWrite(
- base::WrapUnique(new DumpInfo("dump1", "log1", now, params)));
+ base::MakeUnique<DumpInfo>("dump1", "log1", now, params));
const int max_dumps = SynchronizedMinidumpManager::kRatelimitPeriodMaxDumps;
produce_dumps(producer, max_dumps + 1);
@@ -425,7 +425,7 @@ TEST_F(SynchronizedMinidumpManagerTest, UploadSucceedsAfterRateLimitPeriodEnd) {
FakeSynchronizedMinidumpUploader uploader;
SynchronizedMinidumpManagerSimple producer;
producer.SetDumpInfoToWrite(
- base::WrapUnique(new DumpInfo("dump1", "log1", now, params)));
+ base::MakeUnique<DumpInfo>("dump1", "log1", now, params));
const int iters = 3;
const int max_dumps = SynchronizedMinidumpManager::kRatelimitPeriodMaxDumps;
@@ -471,7 +471,7 @@ TEST_F(SynchronizedMinidumpManagerTest, HasDumpsWithDumps) {
FakeSynchronizedMinidumpUploader uploader;
producer.SetDumpInfoToWrite(
- base::WrapUnique(new DumpInfo("dump1", "log1", now, params)));
+ base::MakeUnique<DumpInfo>("dump1", "log1", now, params));
const int kNumDumps = 3;
for (int i = 0; i < kNumDumps; ++i) {
« no previous file with comments | « chromecast/crash/linux/synchronized_minidump_manager.cc ('k') | chromecast/media/cdm/cast_cdm_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698