Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: chromecast/crash/linux/synchronized_minidump_manager.cc

Issue 2258493003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/crash/linux/synchronized_minidump_manager.cc
diff --git a/chromecast/crash/linux/synchronized_minidump_manager.cc b/chromecast/crash/linux/synchronized_minidump_manager.cc
index 6a0a0a7708ccdc99aa884b20a1113b8f238ff5ee..f2a1a2827369a3c9def12fe98e94f5123ac5eba5 100644
--- a/chromecast/crash/linux/synchronized_minidump_manager.cc
+++ b/chromecast/crash/linux/synchronized_minidump_manager.cc
@@ -238,8 +238,7 @@ bool SynchronizedMinidumpManager::ParseFiles() {
std::vector<std::string> lines = base::SplitString(
lockfile, "\n", base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
- std::unique_ptr<base::ListValue> dumps =
- base::WrapUnique(new base::ListValue());
+ std::unique_ptr<base::ListValue> dumps = base::MakeUnique<base::ListValue>();
// Validate dumps
for (const std::string& line : lines) {
@@ -282,15 +281,14 @@ bool SynchronizedMinidumpManager::WriteFiles(const base::ListValue* dumps,
bool SynchronizedMinidumpManager::InitializeFiles() {
std::unique_ptr<base::DictionaryValue> metadata =
- base::WrapUnique(new base::DictionaryValue());
+ base::MakeUnique<base::DictionaryValue>();
base::DictionaryValue* ratelimit_fields = new base::DictionaryValue();
metadata->Set(kLockfileRatelimitKey, base::WrapUnique(ratelimit_fields));
ratelimit_fields->SetDouble(kLockfileRatelimitPeriodStartKey, 0.0);
ratelimit_fields->SetInteger(kLockfileRatelimitPeriodDumpsKey, 0);
- std::unique_ptr<base::ListValue> dumps =
- base::WrapUnique(new base::ListValue());
+ std::unique_ptr<base::ListValue> dumps = base::MakeUnique<base::ListValue>();
return WriteFiles(dumps.get(), metadata.get());
}
« no previous file with comments | « chromecast/crash/linux/dump_info.cc ('k') | chromecast/crash/linux/synchronized_minidump_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698