Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5294)

Unified Diff: chromecast/crash/linux/crash_testing_utils.cc

Issue 2258493003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/url_request_context_factory.cc ('k') | chromecast/crash/linux/dump_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/crash_testing_utils.cc
diff --git a/chromecast/crash/linux/crash_testing_utils.cc b/chromecast/crash/linux/crash_testing_utils.cc
index e90228f59d7184dcbcd5b5424851ca014fb8256c..4649fc9924fa222d5cae21ebd953222f712c13b0 100644
--- a/chromecast/crash/linux/crash_testing_utils.cc
+++ b/chromecast/crash/linux/crash_testing_utils.cc
@@ -39,8 +39,7 @@ std::unique_ptr<base::ListValue> ParseLockFile(const std::string& path) {
std::vector<std::string> lines = base::SplitString(
lockfile_string, "\n", base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
- std::unique_ptr<base::ListValue> dumps =
- base::WrapUnique(new base::ListValue());
+ std::unique_ptr<base::ListValue> dumps = base::MakeUnique<base::ListValue>();
// Validate dumps
for (const std::string& line : lines) {
@@ -84,7 +83,7 @@ bool WriteMetadataFile(const std::string& path, const base::Value* metadata) {
std::unique_ptr<DumpInfo> CreateDumpInfo(const std::string& json_string) {
std::unique_ptr<base::Value> value(DeserializeFromJson(json_string));
- return base::WrapUnique(new DumpInfo(value.get()));
+ return base::MakeUnique<DumpInfo>(value.get());
}
bool FetchDumps(const std::string& lockfile_path,
@@ -106,22 +105,21 @@ bool FetchDumps(const std::string& lockfile_path,
bool ClearDumps(const std::string& lockfile_path) {
std::unique_ptr<base::ListValue> dump_list =
- base::WrapUnique(new base::ListValue());
+ base::MakeUnique<base::ListValue>();
return WriteLockFile(lockfile_path, dump_list.get()) == 0;
}
bool CreateFiles(const std::string& lockfile_path,
const std::string& metadata_path) {
std::unique_ptr<base::DictionaryValue> metadata =
- base::WrapUnique(new base::DictionaryValue());
+ base::MakeUnique<base::DictionaryValue>();
base::DictionaryValue* ratelimit_fields = new base::DictionaryValue();
metadata->Set(kRatelimitKey, base::WrapUnique(ratelimit_fields));
ratelimit_fields->SetDouble(kRatelimitPeriodStartKey, 0.0);
ratelimit_fields->SetInteger(kRatelimitPeriodDumpsKey, 0);
- std::unique_ptr<base::ListValue> dumps =
- base::WrapUnique(new base::ListValue());
+ std::unique_ptr<base::ListValue> dumps = base::MakeUnique<base::ListValue>();
return WriteLockFile(lockfile_path, dumps.get()) == 0 &&
WriteMetadataFile(metadata_path, metadata.get());
« no previous file with comments | « chromecast/browser/url_request_context_factory.cc ('k') | chromecast/crash/linux/dump_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698