Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2258493002: Use ScaleToEnclosingRect when converting the viewport to window. (Closed)

Created:
4 years, 4 months ago by lfg
Modified:
4 years, 3 months ago
Reviewers:
oshima, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScaleToEnclosingRect when converting the viewport to window. This guarantees that the viewport is always contained in the window. BUG=none Committed: https://crrev.com/88fd07f9af5311a6e85502aedca5ce94c9ddfe23 Cr-Commit-Position: refs/heads/master@{#414452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M content/renderer/render_widget.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
lfg
+oshima, please take a look.
4 years, 4 months ago (2016-08-17 15:56:28 UTC) #2
oshima
lgtm
4 years, 4 months ago (2016-08-23 20:58:54 UTC) #3
lfg
+piman for OWNERS review.
4 years, 4 months ago (2016-08-24 14:44:41 UTC) #5
piman
lgtm
4 years, 4 months ago (2016-08-24 17:31:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258493002/1
4 years, 4 months ago (2016-08-24 17:58:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/129028)
4 years, 4 months ago (2016-08-24 19:44:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258493002/1
4 years, 3 months ago (2016-08-25 15:48:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 16:23:28 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/88fd07f9af5311a6e85502aedca5ce94c9ddfe23 Cr-Commit-Position: refs/heads/master@{#414452}
4 years, 3 months ago (2016-08-25 16:26:06 UTC) #15
johnme
On 2016/08/25 16:26:06, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 3 months ago (2016-08-25 17:23:23 UTC) #16
lfg
On 2016/08/25 17:23:23, johnme wrote: > On 2016/08/25 16:26:06, commit-bot: I haz the power wrote: ...
4 years, 3 months ago (2016-08-25 17:44:07 UTC) #17
lfg
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2279873002/ by lfg@chromium.org. ...
4 years, 3 months ago (2016-08-25 17:44:40 UTC) #18
johnme
4 years, 3 months ago (2016-08-25 17:58:14 UTC) #19
Message was sent while issue was closed.
Thanks for reverting. It also seems to have broken
virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance.html
Across these bots: WebKit Linux WebKit Linux Leak WebKit Linux Trusty WebKit
Win10 WebKit Win7

Powered by Google App Engine
This is Rietveld 408576698