|
|
DescriptionUse ScaleToEnclosingRect when converting the viewport to window.
This guarantees that the viewport is always contained in the window.
BUG=none
Committed: https://crrev.com/88fd07f9af5311a6e85502aedca5ce94c9ddfe23
Cr-Commit-Position: refs/heads/master@{#414452}
Patch Set 1 #
Messages
Total messages: 19 (6 generated)
lfg@chromium.org changed reviewers: + oshima@chromium.org
+oshima, please take a look.
lgtm
lfg@chromium.org changed reviewers: + piman@chromium.org
+piman for OWNERS review.
lgtm
The CQ bit was checked by lfg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by lfg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use ScaleToEnclosingRect when converting the viewport to window. This guarantees that the viewport is always contained in the window. BUG=none ========== to ========== Use ScaleToEnclosingRect when converting the viewport to window. This guarantees that the viewport is always contained in the window. BUG=none Committed: https://crrev.com/88fd07f9af5311a6e85502aedca5ce94c9ddfe23 Cr-Commit-Position: refs/heads/master@{#414452} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/88fd07f9af5311a6e85502aedca5ce94c9ddfe23 Cr-Commit-Position: refs/heads/master@{#414452}
Message was sent while issue was closed.
On 2016/08/25 16:26:06, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/88fd07f9af5311a6e85502aedca5ce94c9ddfe23 > Cr-Commit-Position: refs/heads/master@{#414452} It seems this may have broken virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance.html on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6...
Message was sent while issue was closed.
On 2016/08/25 17:23:23, johnme wrote: > On 2016/08/25 16:26:06, commit-bot: I haz the power wrote: > > Patchset 1 (id:??) landed as > > https://crrev.com/88fd07f9af5311a6e85502aedca5ce94c9ddfe23 > > Cr-Commit-Position: refs/heads/master@{#414452} > > It seems this may have broken > virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance.html > on > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6... Just checked, it seems wrong. I'll revert for now.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2279873002/ by lfg@chromium.org. The reason for reverting is: This seems to have broken virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance.html..
Message was sent while issue was closed.
Thanks for reverting. It also seems to have broken virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance.html Across these bots: WebKit Linux WebKit Linux Leak WebKit Linux Trusty WebKit Win10 WebKit Win7 |