chrome/browser/signin/chrome_signin_helper.h - Issue 2258483002: X-Chrome-Connected is stripped when it should not be in headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/chrome_signin_helper.h

Issue 2258483002: X-Chrome-Connected is stripped when it should not be in headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc ('k') | chrome/browser/signin/chrome_signin_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/chrome_signin_helper.h

diff --git a/chrome/browser/signin/chrome_signin_helper.h b/chrome/browser/signin/chrome_signin_helper.h

index 76e7082aa1c3f42bb0713f011b0f65a32dba2169..104b04b068964814598252db51e44c7c6316842a 100644

--- a/chrome/browser/signin/chrome_signin_helper.h

+++ b/chrome/browser/signin/chrome_signin_helper.h

@@ -24,11 +24,13 @@ namespace signin {

// with the exception of requests from gaia webview. Must be called on IO

// thread.

// Returns true if the account management header was added to the request.

-bool AppendMirrorRequestHeaderHelper(net::URLRequest* request,

- const GURL& redirect_url,

- ProfileIOData* io_data,

- int child_id,

- int route_id);

+// Removes X-Chrome-Connected header if it is already in the headers and

+// it should not be there.

+void FixMirrorRequestHeaderHelper(net::URLRequest* request,

+ const GURL& redirect_url,

+ ProfileIOData* io_data,

+ int child_id,

+ int route_id);

// Looks for the X-Chrome-Manage-Accounts response header, and if found,

// tries to show the avatar bubble in the browser identified by the