Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2258463002: Cast for fuzzer complaint (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cast for fuzzer complaint Given the cast in the following else block, this isn't the first time we've encountered this. BUG=637187 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258463002 Committed: https://skia.googlesource.com/skia/+/4c56b9fa714d1bee54666adf7e5e1db5fb398dc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/gpu/GrSurface.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
robertphillips
4 years, 4 months ago (2016-08-17 14:13:35 UTC) #4
bsalomon
lgtm, should we rename this "Worst" rather than "Worse"?
4 years, 4 months ago (2016-08-17 14:37:02 UTC) #9
robertphillips
On 2016/08/17 14:37:02, bsalomon wrote: > lgtm, should we rename this "Worst" rather than "Worse"? ...
4 years, 4 months ago (2016-08-17 15:01:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258463002/1
4 years, 4 months ago (2016-08-17 15:01:56 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 15:02:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4c56b9fa714d1bee54666adf7e5e1db5fb398dc7

Powered by Google App Engine
This is Rietveld 408576698