Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: Source/core/testing/LayerRect.h

Issue 225843002: Oilpan: move ClientRect and its list to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/testing/LayerRect.h
diff --git a/Source/core/testing/LayerRect.h b/Source/core/testing/LayerRect.h
index 559dfd90b5b89539fbf1863c9dad0ddf2b92fabb..907f162761b81dff942d71e15a9e59238cb1e775 100644
--- a/Source/core/testing/LayerRect.h
+++ b/Source/core/testing/LayerRect.h
@@ -45,7 +45,7 @@ class Node;
class LayerRect : public RefCountedWillBeGarbageCollectedFinalized<LayerRect> {
Mads Ager (chromium) 2014/04/04 12:56:00 FINAL (to explain that you do not need the trace m
sof 2014/04/04 13:04:15 Yes, done.
public:
- static PassRefPtrWillBeRawPtr<LayerRect> create(PassRefPtr<Node> node, const String& layerType, PassRefPtr<ClientRect> rect)
+ static PassRefPtrWillBeRawPtr<LayerRect> create(PassRefPtr<Node> node, const String& layerType, PassRefPtrWillBeRawPtr<ClientRect> rect)
{
return adoptRefWillBeNoop(new LayerRect(node, layerType, rect));
}
@@ -54,10 +54,13 @@ public:
String layerType() const { return m_layerType; }
ClientRect* layerRelativeRect() const { return m_rect.get(); }
- void trace(Visitor*) { }
+ void trace(Visitor* visitor)
+ {
+ visitor->trace(m_rect);
+ }
private:
- LayerRect(PassRefPtr<Node> node, const String& layerName, PassRefPtr<ClientRect> rect)
+ LayerRect(PassRefPtr<Node> node, const String& layerName, PassRefPtrWillBeRawPtr<ClientRect> rect)
: m_layerRootNode(node)
, m_layerType(layerName)
, m_rect(rect)
@@ -66,7 +69,7 @@ private:
RefPtr<Node> m_layerRootNode;
String m_layerType;
- RefPtr<ClientRect> m_rect;
+ RefPtrWillBeMember<ClientRect> m_rect;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698