Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 225843002: Oilpan: move ClientRect and its list to the oilpan heap. (Closed)

Created:
6 years, 8 months ago by sof
Modified:
6 years, 8 months ago
CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, watchdog-blink-watchlist_google.com, rwlbuis, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add missing FINALs #

Total comments: 2

Patch Set 3 : Rebased + code style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -64 lines) Patch
M Source/core/dom/ClientRect.h View 1 chunk +30 lines, -18 lines 0 comments Download
M Source/core/dom/ClientRect.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ClientRectList.h View 2 chunks +13 lines, -4 lines 0 comments Download
M Source/core/dom/ClientRectList.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/ClientRectList.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Range.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Range.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/Page.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 6 chunks +11 lines, -11 lines 0 comments Download
M Source/core/testing/Internals.cpp View 9 chunks +11 lines, -11 lines 0 comments Download
M Source/core/testing/LayerRect.h View 1 3 chunks +8 lines, -5 lines 0 comments Download
M Source/core/testing/LayerRectList.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/LayerRectList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
sof
Please take a look. For completeness.
6 years, 8 months ago (2014-04-04 12:45:25 UTC) #1
Mads Ager (chromium)
LGTM https://codereview.chromium.org/225843002/diff/1/Source/core/testing/LayerRect.h File Source/core/testing/LayerRect.h (right): https://codereview.chromium.org/225843002/diff/1/Source/core/testing/LayerRect.h#newcode46 Source/core/testing/LayerRect.h:46: class LayerRect : public RefCountedWillBeGarbageCollectedFinalized<LayerRect> { FINAL (to ...
6 years, 8 months ago (2014-04-04 12:56:00 UTC) #2
sof
Thanks for the quick review. https://codereview.chromium.org/225843002/diff/1/Source/core/testing/LayerRect.h File Source/core/testing/LayerRect.h (right): https://codereview.chromium.org/225843002/diff/1/Source/core/testing/LayerRect.h#newcode46 Source/core/testing/LayerRect.h:46: class LayerRect : public ...
6 years, 8 months ago (2014-04-04 13:04:14 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-04 13:06:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/225843002/20001
6 years, 8 months ago (2014-04-04 13:06:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 13:14:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-04 13:14:36 UTC) #7
sof
On 2014/04/04 13:14:36, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 8 months ago (2014-04-04 13:24:01 UTC) #8
haraken
LGTM.
6 years, 8 months ago (2014-04-04 13:44:37 UTC) #9
sof
jochen: Source/web/ change looks ok?
6 years, 8 months ago (2014-04-04 13:49:03 UTC) #10
tkent
lgtm https://codereview.chromium.org/225843002/diff/20001/Source/core/dom/ClientRectList.cpp File Source/core/dom/ClientRectList.cpp (right): https://codereview.chromium.org/225843002/diff/20001/Source/core/dom/ClientRectList.cpp#newcode67 Source/core/dom/ClientRectList.cpp:67: void ClientRectList::trace(Visitor *visitor) Visitor *visitor -> Visitor* visitor
6 years, 8 months ago (2014-04-07 02:00:09 UTC) #11
sof
https://codereview.chromium.org/225843002/diff/20001/Source/core/dom/ClientRectList.cpp File Source/core/dom/ClientRectList.cpp (right): https://codereview.chromium.org/225843002/diff/20001/Source/core/dom/ClientRectList.cpp#newcode67 Source/core/dom/ClientRectList.cpp:67: void ClientRectList::trace(Visitor *visitor) On 2014/04/07 02:00:10, tkent wrote: > ...
6 years, 8 months ago (2014-04-07 06:07:53 UTC) #12
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-07 06:08:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/225843002/40001
6 years, 8 months ago (2014-04-07 06:08:09 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 07:09:56 UTC) #15
Message was sent while issue was closed. 
Change committed as 170951

Powered by Google App Engine
This is Rietveld 408576698