Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2258343002: Change GPU Tile rounding to 32 (Closed)

Created:
4 years, 4 months ago by ericrk
Modified:
4 years, 4 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, blink-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change GPU Tile rounding to 32 Rounding to 64 was done to match SW, but this leads to android memory regressions. Use 32 instead, which still fixes the Core Animation issue, but doesn’t regress memory as much. BUG=632274 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/55f181c683f26d1d43f264367363790a802e096d Cr-Commit-Position: refs/heads/master@{#413310}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
ericrk
4 years, 4 months ago (2016-08-19 23:48:58 UTC) #4
vmpstr
lgtm
4 years, 4 months ago (2016-08-19 23:50:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258343002/40001
4 years, 4 months ago (2016-08-19 23:55:13 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-20 02:35:13 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 02:36:59 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/55f181c683f26d1d43f264367363790a802e096d
Cr-Commit-Position: refs/heads/master@{#413310}

Powered by Google App Engine
This is Rietveld 408576698