Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2258333004:
Fix compiling with CUPS 2.2 backend. (Closed)
|
Created:
4 years, 4 months ago by saiarcot895 Modified:
4 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix compiling with CUPS 2.2 backend.
cupsGetPPD() and cupsGetPPD2() have been moved into the cups/ppd.h
header starting with CUPS 2.2. This header file now needs to be included
to use these functions. The header file also exists on older versions of
CUPS, so a compile error will not occur.
R=skau@chromium.org, thestig@chromium.org
Committed: https://crrev.com/5132ca58a0a3ada1aee99732fd30d53ebe5af984
Cr-Commit-Position: refs/heads/master@{#413484}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== Fix compiling with CUPS 2.2 backend. cupsGetPPD() and cupsGetPPD2() have been moved into the cups/ppd.h header starting with CUPS 2.2. This header file now needs to be included to use these functions. The header file also exists on older versions of CUPS, so a compile error will not occur. R=jam@chromium.org, thestig@chromium.org BUG= ========== to ========== Fix compiling with CUPS 2.2 backend. cupsGetPPD() and cupsGetPPD2() have been moved into the cups/ppd.h header starting with CUPS 2.2. This header file now needs to be included to use these functions. The header file also exists on older versions of CUPS, so a compile error will not occur. R=jam@chromium.org, thestig@chromium.org BUG= ==========
jam@chromium.org changed reviewers: - jam@chromium.org
not sure why I was added, removing myself
Description was changed from ========== Fix compiling with CUPS 2.2 backend. cupsGetPPD() and cupsGetPPD2() have been moved into the cups/ppd.h header starting with CUPS 2.2. This header file now needs to be included to use these functions. The header file also exists on older versions of CUPS, so a compile error will not occur. R=jam@chromium.org, thestig@chromium.org BUG= ========== to ========== Fix compiling with CUPS 2.2 backend. cupsGetPPD() and cupsGetPPD2() have been moved into the cups/ppd.h header starting with CUPS 2.2. This header file now needs to be included to use these functions. The header file also exists on older versions of CUPS, so a compile error will not occur. R=skau@chromium.org, thestig@chromium.org ==========
thestig@chromium.org changed reviewers: + skau@chromium.org
skau: PTAL
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/22 17:08:54, Lei Zhang wrote: > skau: PTAL lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thestig@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix compiling with CUPS 2.2 backend. cupsGetPPD() and cupsGetPPD2() have been moved into the cups/ppd.h header starting with CUPS 2.2. This header file now needs to be included to use these functions. The header file also exists on older versions of CUPS, so a compile error will not occur. R=skau@chromium.org, thestig@chromium.org ========== to ========== Fix compiling with CUPS 2.2 backend. cupsGetPPD() and cupsGetPPD2() have been moved into the cups/ppd.h header starting with CUPS 2.2. This header file now needs to be included to use these functions. The header file also exists on older versions of CUPS, so a compile error will not occur. R=skau@chromium.org, thestig@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix compiling with CUPS 2.2 backend. cupsGetPPD() and cupsGetPPD2() have been moved into the cups/ppd.h header starting with CUPS 2.2. This header file now needs to be included to use these functions. The header file also exists on older versions of CUPS, so a compile error will not occur. R=skau@chromium.org, thestig@chromium.org ========== to ========== Fix compiling with CUPS 2.2 backend. cupsGetPPD() and cupsGetPPD2() have been moved into the cups/ppd.h header starting with CUPS 2.2. This header file now needs to be included to use these functions. The header file also exists on older versions of CUPS, so a compile error will not occur. R=skau@chromium.org, thestig@chromium.org Committed: https://crrev.com/5132ca58a0a3ada1aee99732fd30d53ebe5af984 Cr-Commit-Position: refs/heads/master@{#413484} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5132ca58a0a3ada1aee99732fd30d53ebe5af984 Cr-Commit-Position: refs/heads/master@{#413484} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
