Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: public/fpdf_formfill.h

Issue 2258333002: Fix page leaks in an embedder test (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« fpdfsdk/fsdk_mgr.cpp ('K') | « fpdfsdk/fsdk_mgr.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/fpdf_formfill.h
diff --git a/public/fpdf_formfill.h b/public/fpdf_formfill.h
index 248bcd2b023306b2ad7d5d027555561fcb62d0e2..e836388f92510d942e42de7e78806b0eb35385b9 100644
--- a/public/fpdf_formfill.h
+++ b/public/fpdf_formfill.h
@@ -575,6 +575,8 @@ typedef struct _FPDF_FORMFILLINFO {
* page which hadn't been loaded yet.
* To successfully run the javascript action, implementation need to load
* the page for SDK.
+ * If getting a CPDFXFA_Page from this function, needs to call release()
+ * on that page when finished.
* */
FPDF_PAGE (*FFI_GetPage)(struct _FPDF_FORMFILLINFO* pThis,
FPDF_DOCUMENT document,
« fpdfsdk/fsdk_mgr.cpp ('K') | « fpdfsdk/fsdk_mgr.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698