Issue 225833002: simple cache: testing: AddDelay() between evictable entry sets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225833002: simple cache: testing: AddDelay() between evictable entry sets (Closed)

Created:
6 years, 8 months ago by pasko

Modified:
6 years, 8 months ago

Reviewers:
Alexander Potapenko, gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

simple cache: testing: AddDelay() between evictable entry sets We switched to very coarse-grained timestamps in the backend. This requires adding synthetic delays in tests to make different timestamps for different subsets of entries. We added one delay in the test, but forgot about the other. This change separates the last two entries from the rest with a delay. With the delay the current eviction algorithm (i.e. sort by timestamp, evict down to the low watermark), should not evict these two last entries. BUG=234776 TBR=gavinp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262070