Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2258273002: Consistently use namespaced base::Version in gpu/ code. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistently use namespaced base::Version in gpu/ code. BUG=639416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/9484f3a00bf11f6c73b556aed42f21b64cca0c66 Cr-Commit-Position: refs/heads/master@{#413295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M gpu/config/gpu_info.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pwnall
Can you please take a look? This is pretty mechanic CL.
4 years, 4 months ago (2016-08-19 20:46:13 UTC) #3
aelias_OOO_until_Jul13
lgtm
4 years, 4 months ago (2016-08-19 20:54:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258273002/1
4 years, 4 months ago (2016-08-20 00:18:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 00:34:54 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 00:39:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9484f3a00bf11f6c73b556aed42f21b64cca0c66
Cr-Commit-Position: refs/heads/master@{#413295}

Powered by Google App Engine
This is Rietveld 408576698