Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2258233002:
SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. (Closed)
|
Created:
4 years, 4 months ago by hal.canary Modified:
4 years, 3 months ago Reviewers:
bungeman-skia CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName.
Also, minor code refactoring.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002
Committed: https://skia.googlesource.com/skia/+/fce190647285423bf36c44bca09db78a6af30f9f
Committed: https://skia.googlesource.com/skia/+/426a2459290a57bf32151f042fe5cd67da61d02f
Patch Set 1 #Patch Set 2 : 2016-08-19 (Friday) 15:01:30 EDT #Patch Set 3 : a little clenaup #Patch Set 4 : SK_BUILD_FOR_ANDROID_FRAMEWORK #Patch Set 5 : TODO #Patch Set 6 : 2016-08-30 (Tuesday) 16:51:57 EDT #Patch Set 7 : rebase #Messages
Total messages: 33 (24 generated)
Description was changed from ========== SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. Also, minor code refactoring. ========== to ========== SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. Also, minor code refactoring. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002 ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
halcanary@google.com changed reviewers: + bungeman@google.com
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
The CQ bit was checked by bungeman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm once Chromium has the code
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/19 19:03:53, bungeman-skia wrote: > lgtm once Chromium has the code Chromium is ready. I did a little more cleanup and rebased. I'll land today if no objection.
The CQ bit was checked by bungeman@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com Link to the patchset: https://codereview.chromium.org/2258233002/#ps40001 (title: "a little clenaup")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. Also, minor code refactoring. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002 ========== to ========== SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. Also, minor code refactoring. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002 Committed: https://skia.googlesource.com/skia/+/fce190647285423bf36c44bca09db78a6af30f9f ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/fce190647285423bf36c44bca09db78a6af30f9f
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2296683004/ by halcanary@google.com. The reason for reverting is: forgot to roll sfntly in android!.
Message was sent while issue was closed.
Description was changed from ========== SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. Also, minor code refactoring. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002 Committed: https://skia.googlesource.com/skia/+/fce190647285423bf36c44bca09db78a6af30f9f ========== to ========== SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. Also, minor code refactoring. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002 Committed: https://skia.googlesource.com/skia/+/fce190647285423bf36c44bca09db78a6af30f9f ==========
The CQ bit was checked by halcanary@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com Link to the patchset: https://codereview.chromium.org/2258233002/#ps80001 (title: "TODO")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by halcanary@google.com
The CQ bit was checked by halcanary@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com Link to the patchset: https://codereview.chromium.org/2258233002/#ps120001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. Also, minor code refactoring. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002 Committed: https://skia.googlesource.com/skia/+/fce190647285423bf36c44bca09db78a6af30f9f ========== to ========== SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. Also, minor code refactoring. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002 Committed: https://skia.googlesource.com/skia/+/fce190647285423bf36c44bca09db78a6af30f9f Committed: https://skia.googlesource.com/skia/+/426a2459290a57bf32151f042fe5cd67da61d02f ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/426a2459290a57bf32151f042fe5cd67da61d02f |
