components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc - Issue 225823006: Rewrite functions from WebPasswordFormData and WebPasswordFormUtils in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

Issue 225823006: Rewrite functions from WebPasswordFormData and WebPasswordFormUtils in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Put check on "isActivatedSumbit" back Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_form_conversion_utils.cc ('K') | « components/autofill/content/renderer/password_form_conversion_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

index d0f55062698ae5f167936e63741a7ef9f0be96d4..987b5d60551c8aa5dae5134d27ac0623a5e518d8 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

@@ -12,11 +12,9 @@

#include "third_party/WebKit/public/web/WebDocument.h"

#include "third_party/WebKit/public/web/WebFormElement.h"

#include "third_party/WebKit/public/web/WebLocalFrame.h"

-#include "third_party/WebKit/public/web/WebPasswordFormData.h"

using blink::WebFormElement;

using blink::WebFrame;

-using blink::WebPasswordFormData;

using blink::WebVector;

namespace autofill {

@@ -48,8 +46,6 @@ TEST_F(PasswordFormConversionUtilsTest, ValidWebFormElementToPasswordForm) {

WebVector<WebFormElement> forms;

frame->document().forms(forms);

ASSERT_EQ(1U, forms.size());

- WebPasswordFormData web_password_form(forms[0]);

- ASSERT_TRUE(web_password_form.isValid());

scoped_ptr<PasswordForm> password_form = CreatePasswordForm(forms[0]);

ASSERT_NE(static_cast<PasswordForm*>(NULL), password_form.get());

@@ -82,8 +78,6 @@ TEST_F(PasswordFormConversionUtilsTest, InvalidWebFormElementToPasswordForm) {

WebVector<WebFormElement> forms;

frame->document().forms(forms);

ASSERT_EQ(1U, forms.size());

- WebPasswordFormData web_password_form(forms[0]);

- ASSERT_FALSE(web_password_form.isValid());

scoped_ptr<PasswordForm> password_form = CreatePasswordForm(forms[0]);

EXPECT_EQ(static_cast<PasswordForm*>(NULL), password_form.get());