src/ast.h - Issue 225823003: Implement handlified String::Equals and Name::Equals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.h

Issue 225823003: Implement handlified String::Equals and Name::Equals. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: refactored StringToDouble Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.h

diff --git a/src/ast.h b/src/ast.h

index 486db60a77ff21efb581c84135a1333baa0ff18d..ed3a8b6ee34eb72a14975eb6dc6e22d5099ad39f 100644

--- a/src/ast.h

+++ b/src/ast.h

@@ -1394,7 +1394,7 @@ class Literal V8_FINAL : public Expression {

static bool Match(void* literal1, void* literal2) {

Handle<String> s1 = static_cast<Literal*>(literal1)->ToString();

Handle<String> s2 = static_cast<Literal*>(literal2)->ToString();

- return s1->Equals(*s2);

+ return String::Equals(s1, s2);

}

TypeFeedbackId LiteralFeedbackId() const { return reuse(id()); }

« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/ast.cc » ('j') | no next file with comments »