src/factory.cc - Issue 225823003: Implement handlified String::Equals and Name::Equals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 225823003: Implement handlified String::Equals and Name::Equals. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 866a6556abcced8b2821da2c7ce75c101852c893..62888152918c1d1c1dc91d8cc90c33959f86714e 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1981,10 +1981,9 @@ void Factory::ConfigureInstance(Handle<FunctionTemplateInfo> desc,

Handle<Object> Factory::GlobalConstantFor(Handle<String> name) {

- Heap* h = isolate()->heap();

- if (name->Equals(h->undefined_string())) return undefined_value();

- if (name->Equals(h->nan_string())) return nan_value();

- if (name->Equals(h->infinity_string())) return infinity_value();

+ if (String::Equals(name, undefined_string())) return undefined_value();

+ if (String::Equals(name, nan_string())) return nan_value();

+ if (String::Equals(name, infinity_string())) return infinity_value();

return Handle<Object>::null();

}