Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 225823003: Implement handlified String::Equals and Name::Equals. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Implement handlified String::Equals and Name::Equals. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20669

Patch Set 1 #

Total comments: 1

Patch Set 2 : refactored StringToDouble #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -448 lines) Patch
M src/accessors.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M src/api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M src/ast.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/compilation-cache.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/contexts.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/conversions.h View 1 2 chunks +11 lines, -1 line 0 comments Download
M src/conversions.cc View 2 chunks +18 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/func-name-inferrer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/heap-inl.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M src/ic.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/json-parser.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M src/objects.h View 7 chunks +27 lines, -32 lines 0 comments Download
M src/objects.cc View 8 chunks +60 lines, -87 lines 0 comments Download
M src/objects-inl.h View 3 chunks +20 lines, -16 lines 0 comments Download
M src/parser.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M src/runtime.cc View 1 16 chunks +89 lines, -109 lines 0 comments Download
M src/scanner.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/v8conversions.h View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/v8conversions.cc View 1 2 chunks +12 lines, -44 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Also removes the last use of non-handlified String::TryFlatten
6 years, 8 months ago (2014-04-08 14:24:41 UTC) #1
ulan
lgtm https://codereview.chromium.org/225823003/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/225823003/diff/1/src/api.cc#newcode2998 src/api.cc:2998: i::String::Equals(i::Handle<i::String>::cast(obj), Since you have the isolate, you could ...
6 years, 8 months ago (2014-04-10 13:59:26 UTC) #2
Yang
6 years, 8 months ago (2014-04-11 07:27:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20669 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698