Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 22582009: Improve time resolution in PlatformFileInfo. (Closed)

Created:
7 years, 4 months ago by gavinp
Modified:
7 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Improve time resolution in PlatformFileInfo. The Simple Cache uses directory and file mtimes at high granularity to determine index freshness. As well, for linux process creation times, a high resolution ctime from /proc is useful; so high resolution ctime makes process creation times accurate. R=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216478

Patch Set 1 #

Patch Set 2 : fix fat finger #

Total comments: 2

Patch Set 3 : add comment #

Patch Set 4 : one more TODO for gavinp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -38 lines) Patch
M base/platform_file_posix.cc View 1 2 1 chunk +44 lines, -3 lines 0 comments Download
M net/disk_cache/simple/simple_util.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_util.cc View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gavinp
Darin, Higher resolution times are always useful. They are particularly important for https://codereview.chromium.org/22594007/ .
7 years, 4 months ago (2013-08-07 16:42:02 UTC) #1
darin (slow to review)
Is there anything needed for Windows? LGTM https://codereview.chromium.org/22582009/diff/19001/base/platform_file_posix.cc File base/platform_file_posix.cc (right): https://codereview.chromium.org/22582009/diff/19001/base/platform_file_posix.cc#newcode405 base/platform_file_posix.cc:405: const time_t ...
7 years, 4 months ago (2013-08-07 18:17:28 UTC) #2
gavinp
On 2013/08/07 18:17:28, darin wrote: > Is there anything needed for Windows? Windows is already ...
7 years, 4 months ago (2013-08-07 18:24:33 UTC) #3
gavinp
Thanks! https://codereview.chromium.org/22582009/diff/19001/base/platform_file_posix.cc File base/platform_file_posix.cc (right): https://codereview.chromium.org/22582009/diff/19001/base/platform_file_posix.cc#newcode405 base/platform_file_posix.cc:405: const time_t last_modified_sec = file_info.st_mtime; On 2013/08/07 18:17:28, ...
7 years, 4 months ago (2013-08-07 18:24:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/22582009/49001
7 years, 4 months ago (2013-08-07 21:13:20 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-08 23:12:01 UTC) #6
Message was sent while issue was closed.
Change committed as 216478

Powered by Google App Engine
This is Rietveld 408576698