Qualify skia gl include properly.

Qualify skia gl includes properly in GraphicsContext3D.
    
skia's public include path isn't supposed to include gpu/gl; update
GraphicsContext3D.cpp to refer to skia headers with fully qualified
paths so that Chromium doesn't need to include extra directories.

BUG=
R=jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155836

[Torne, 2013-08-07 15:19:28]

Hi James, can you review this? Trying to fix a mismatch between the way Chromium
builds skia and skia builds standalone; djsollen recommended we change this
include so I can drop gpu/gl from skia's include path in chromium.

[jamesr, 2013-08-07 18:03:56]

https://codereview.chromium.org/22582006/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/GraphicsContext3D.cpp (right):

https://codereview.chromium.org/22582006/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/GraphicsContext3D.cpp:42: #include
"gl/GrGLInterface.h"
if you're doing this, better to fully qualify the skia paths here as in

#include "third_party/skia/include/gpu/gl/..."

same for GrContext.h

[Torne, 2013-08-07 21:35:10]

On 2013/08/07 18:03:56, jamesr wrote:
>
https://codereview.chromium.org/22582006/diff/1/Source/core/platform/graphics...
> File Source/core/platform/graphics/GraphicsContext3D.cpp (right):
> 
>
https://codereview.chromium.org/22582006/diff/1/Source/core/platform/graphics...
> Source/core/platform/graphics/GraphicsContext3D.cpp:42: #include
> "gl/GrGLInterface.h"
> if you're doing this, better to fully qualify the skia paths here as in
> 
> #include "third_party/skia/include/gpu/gl/..."
> 
> same for GrContext.h

Sure, I can do that. I guess we should do that throughout Blink really? I'll
amend this CL to do it for this one file (as I need this specific include fixed
soon for boring reasons) but I can propose a big patch to do it throughout Blink
if that's desirable..

[tfarina, 2013-08-07 21:40:10]

On Wed, Aug 7, 2013 at 6:35 PM,  <torne@chromium.org> wrote:
> On 2013/08/07 18:03:56, jamesr wrote:
>
>
https://codereview.chromium.org/22582006/diff/1/Source/core/platform/graphics...
>>
>> File Source/core/platform/graphics/GraphicsContext3D.cpp (right):
>
>
>
>
https://codereview.chromium.org/22582006/diff/1/Source/core/platform/graphics...
>>
>> Source/core/platform/graphics/GraphicsContext3D.cpp:42: #include
>> "gl/GrGLInterface.h"
>> if you're doing this, better to fully qualify the skia paths here as in
>
>
>> #include "third_party/skia/include/gpu/gl/..."
>
>
>> same for GrContext.h
>
>
> Sure, I can do that. I guess we should do that throughout Blink really? I'll
> amend this CL to do it for this one file (as I need this specific include
> fixed
> soon for boring reasons) but I can propose a big patch to do it throughout
> Blink
> if that's desirable..
>
I have been thinking about this, but haven't talk about this with
anyone. I really would like to see us using full paths to skia
includes.

If you can send an email to blink-dev, then we can discuss this there.

> https://codereview.chromium.org/22582006/



-- 
Thiago

[jamesr, 2013-08-07 22:17:54]

On 2013/08/07 21:35:10, Torne wrote:
> On 2013/08/07 18:03:56, jamesr wrote:
> >
>
https://codereview.chromium.org/22582006/diff/1/Source/core/platform/graphics...
> > File Source/core/platform/graphics/GraphicsContext3D.cpp (right):
> > 
> >
>
https://codereview.chromium.org/22582006/diff/1/Source/core/platform/graphics...
> > Source/core/platform/graphics/GraphicsContext3D.cpp:42: #include
> > "gl/GrGLInterface.h"
> > if you're doing this, better to fully qualify the skia paths here as in
> > 
> > #include "third_party/skia/include/gpu/gl/..."
> > 
> > same for GrContext.h
> 
> Sure, I can do that. I guess we should do that throughout Blink really? I'll
> amend this CL to do it for this one file (as I need this specific include
fixed
> soon for boring reasons) but I can propose a big patch to do it throughout
Blink
> if that's desirable..

It's desirable to do across the board, but doesn't provide a tremendous benefit
so nobody's driven a change across the board.  The way skia headers work
anything that sees a skia header still has to have all of skia's include paths
on their compile line, so we can't shorten the include paths we pass to the
compiler :(

Since you have a concrete need here I'd recommend just patching this file and
then if you want to code up a big patch (or more realistically several big
patches) to fix all of Blink do it separately.

[Torne, 2013-08-08 10:26:00]

OK, I've updated this file to use fully qualified paths from src/.

[jamesr, 2013-08-08 19:53:25]

cool! lgtm

[Torne, 2013-08-09 11:06:56]

Committed patchset #2 manually as r155836 (presubmit successful).