third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc - Issue 2258133002: [scheduler] Implement time-based cpu throttling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

Issue 2258133002: [scheduler] Implement time-based cpu throttling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One more fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/scheduler/base/test_task_time_observer.h ('K') | « third_party/WebKit/Source/platform/scheduler/base/time_domain.cc ('k') | third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc » ('j') | third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

index 610b95b304f5838222707ad1153108d352959a3d..e69565035354324f72b09260ddb74ee19d300a36 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

@@ -279,8 +279,8 @@ class MockObserver : public TimeDomain::Observer {

public:

~MockObserver() override {}

- MOCK_METHOD0(OnTimeDomainHasImmediateWork, void());

- MOCK_METHOD0(OnTimeDomainHasDelayedWork, void());

+ MOCK_METHOD1(OnTimeDomainHasImmediateWork, void(TaskQueue*));

+ MOCK_METHOD1(OnTimeDomainHasDelayedWork, void(TaskQueue*));

};

} // namespace

@@ -295,12 +295,12 @@ class TimeDomainWithObserverTest : public TimeDomainTest {

};

TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasImmediateWork) {

- EXPECT_CALL(*observer_, OnTimeDomainHasImmediateWork());

+ EXPECT_CALL(*observer_, OnTimeDomainHasImmediateWork(task_queue_.get()));

time_domain_->RegisterAsUpdatableTaskQueue(task_queue_.get());

}

TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasDelayedWork) {

- EXPECT_CALL(*observer_, OnTimeDomainHasDelayedWork());

+ EXPECT_CALL(*observer_, OnTimeDomainHasDelayedWork(task_queue_.get()));

EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _));

base::TimeTicks now = time_domain_->Now();

time_domain_->ScheduleDelayedWork(