third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h - Issue 2258133002: [scheduler] Implement time-based cpu throttling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h

Issue 2258133002: [scheduler] Implement time-based cpu throttling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed Enable/Disable to Enable/DisableThrottling. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/scheduler/base/time_domain.h ('K') | « third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc ('k') | third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h » ('j') | third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h

diff --git a/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h b/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h

index 02380606dc687b9dd9b47f12cb8a582f24dd6650..5b6b7301bb6028292df7c69938b40d3a03ae4d02 100644

--- a/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h

+++ b/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h

@@ -64,7 +64,7 @@ class BLINK_PLATFORM_EXPORT SchedulerHelper

// Returns true if Shutdown() has been called. Otherwise returns false.

bool IsShutdown() const { return !task_queue_manager_.get(); }

- void CheckOnValidThread() const {

+ inline void CheckOnValidThread() const {

alex clarke (OOO till 29th) 2016/09/15 12:19:35 does this make any difference?

altimin 2016/09/15 15:52:10 It gives us guarantee that we will not call this f

DCHECK(thread_checker_.CalledOnValidThread());

}