third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc - Issue 2258133002: [scheduler] Implement time-based cpu throttling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

Issue 2258133002: [scheduler] Implement time-based cpu throttling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed Enable/Disable to Enable/DisableThrottling. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc ('K') | « third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc ('k') | third_party/WebKit/Source/platform/scheduler/base/test_task_time_observer.h » ('j') | third_party/WebKit/Source/platform/scheduler/base/time_domain.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

index f44ee457a87e5189ddb438b495d6db1920f95be9..f07c0601ae5c59cd18e6e4d635a60a80391cc3fa 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

@@ -226,9 +226,12 @@ void TaskQueueManager::DoWork(base::TimeTicks run_time, bool from_main_thread) {

if (!delegate_->IsNested() && task_start_time != base::TimeTicks()) {

// Only report top level task durations.

base::TimeTicks task_end_time = lazy_now.Now();

alex clarke (OOO till 29th) 2016/09/15 12:19:35 nit: remove blank line here and after the FOR_EACH

altimin 2016/09/15 15:52:10 Done.

FOR_EACH_OBSERVER(TaskTimeObserver, task_time_observers_,

- ReportTaskTime(MonotonicTimeInSeconds(task_start_time),

+ ReportTaskTime(work_queue->task_queue(),

+ MonotonicTimeInSeconds(task_start_time),

MonotonicTimeInSeconds(task_end_time)));

task_start_time = task_end_time;

}